TFSCodeReviewFlow Wiki & Documentation Rss Feed

New Comment on "Installation"

fuentesrdz — Sat, 03 Sep 2011 19:53:08 GMT

Hello CodePlex Team, When I was importing the "Code Review.xml", am getting this error: Error: Field name 'Resolution' is used by the field 'KCS.Common.CR.Resolution', so it cannot be used by the field 'Microsoft.VSTS.Dogfood.Resolution'. Do you know how can I get rid of that issue? Thanks in advance Regards Juan Pablo Fuentes

Updated Wiki: Installation

RyanFarber — Fri, 24 Dec 2010 20:14:05 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" (This needs to be spelled exactly for the work item to find it.) and add a description then hit ok
Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://visualstudiogallery.msdn.microsoft.com/en-us/c255a1e4-04ba-4f68-8f4e-cd473d6b971f

4. Set up Policy Management

Check-in policies have to be installed on the client. If your team doesn't get these installs then they will see a Policy Failure message with an option to override the policy. If not properly informed and if installing the new policies aren't easy they will most likely override the policy.

Develop your own policy update rules or use the one mentioned at the beginning of step 3.
Either create a tool to regularly view policy overrides or setup e-mail notification on policy overrides. You can setup alerts using either BISUBSCRIBE.EXE which ships with the AT server tools or use this tool for Event Subscribing http://www.gotdotnet.com/codegallery/codegallery.aspx?id=6da8d4eb-f456-4e22-9a73-851c7341cff4

5. Create Queries

6. Set up project alerts

New Comment on "Installation"

billdong — Fri, 12 Jun 2009 15:52:40 GMT

If you use VS2008, compile the code with 2008, otherwise Code Review Policy won't show up in the list even you have successfully registered.

New Comment on "Installation"

mwaseemalvi — Fri, 15 May 2009 06:03:10 GMT

Dear All I was trying to install this checking policy on my machine and I have successfully imported the "Code Review.xml". But I am sorry to say I didnt find any process to import "Code Review Policy.dll". How can I replace it or register it so that I can easily access and used this policy. Secodly, the website link which is given in step 3 (http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9) is not working. I am getting the message that the Got Dot net server is shutdown. So please update latest path where we can acess the further steps. Thanks

UPDATED WIKI: Home

RyanFarber — Mon, 15 Oct 2007 20:56:47 GMT

TFS Code Review Workflow

This project is a combination of a Code Review Work Item and a Code Review Check-in Policy. The check-in policy doesn’t allow a check-in unless it has an associated Code Review work item, and that work item is set to approved. Only people in a TFS group named {Project}\Code Reviewers can set an item to approved.

Parts

Code Review Work Item
Code Review Custom Check-In Policy
Code Reviewers Security Group
(optional) Custom Path Policy http://msdn2.microsoft.com/en-us/teamsystem/aa718351.aspx#checkin

see Installation for details

Workflow

Dev finishes code and wants it reviewed so they shelve the changeset and create a Code Review work item and mention the name of the shelf set. This is assigned to a general Code Review team.
People on the code review team have event subscriptions which sends them an e-mail when a workitem is assigned to the Code Review group. One of them will open the work item, review the shelf set and resolve the item as 'Accepted' or 'Needs changes' which assigns it back to the original dev.
Once in an approved state the dev can check-in and associate to the work item which will close it.

What's needed

A custom report to show the reviews, time from open to close, number of attached tasks or bugs, number of activations
More detail in work item?
Some more options to allow for different code reviewer groups. For example on one of my projects the test team want the test code to follow this policy but be assigned to test team code reviewers.
An add-in for VS to automatically shelve and create the workitem.

UPDATED WIKI: Installation

RyanFarber — Fri, 21 Jul 2006 22:28:40 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" (This needs to be spelled exactly for the work item to find it.) and add a description then hit ok
Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Set up Policy Management

Develop your own policy update rules or use the one mentioned at the beginning of step 3.
Either create a tool to regularly view policy overrides or setup e-mail notification on policy overrides. You can setup alerts using either BISUBSCRIBE.EXE which ships with the AT server tools or use this tool for Event Subscribing http://www.gotdotnet.com/codegallery/codegallery.aspx?id=6da8d4eb-f456-4e22-9a73-851c7341cff4

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Home

RyanFarber — Fri, 21 Jul 2006 18:45:45 GMT

TFS Code Review Workflow

Parts

Code Review Work Item
Code Review Custom Check-In Policy
Code Reviewers Security Group
(optional) Custom Path Policy http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

see Installation for details

Workflow

Dev finishes code and wants it reviewed so they shelve the changeset and create a Code Review work item and mention the name of the shelf set. This is assigned to a general Code Review team.
People on the code review team have event subscriptions which sends them an e-mail when a workitem is assigned to the Code Review group. One of them will open the work item, review the shelf set and resolve the item as 'Accepted' or 'Needs changes' which assigns it back to the original dev.
Once in an approved state the dev can check-in and associate to the work item which will close it.

What's needed

A custom report to show the reviews, time from open to close, number of attached tasks or bugs, number of activations
More detail in work item?
Some more options to allow for different code reviewer groups. For example on one of my projects the test team want the test code to follow this policy but be assigned to test team code reviewers.
An add-in for VS to automatically shelve and create the workitem.

UPDATED WIKI: Installation

RyanFarber — Fri, 21 Jul 2006 16:24:52 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" (This needs to be spelled exactly for the work item to find it.) and add a description then hit ok
Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Inform Team

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 21:06:07 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" (This needs to be spelled exactly for the work item to find it.) and add a description then hit ok
Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Inform Team

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 20:59:59 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" (This needs to be spelled exactly for the work item to find it.) and add a description then hit ok
Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Inform Team

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 20:52:01 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template. To add the group

Right-click on the Team Project and select Team Project Settings -> Group Membership...
Click "New..."
Set the group name = "Code Reviewers" and add a description then hit ok

This needs to be spelled exactly for the work item to find it.

Double-click on the new Code Reviewers group and add some members

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Inform Team

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 20:04:10 GMT

Installing Code Review

This following instructions assume you have Admin rights on the TFS Project

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template.

[image:addcodereviewers.gif]

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

Check in policies need to be on each client that will need them and registered for VS to find. I have some tools to aid this process at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=94a79007-aeaa-49a5-b966-99ad655aa4b9
Once you have the policy installed you need to right-click on the Team Project and select Project Settings -> Source Control. On the middle tab you can add the policy.

This policy will apply to all add-ins for the Team Project. You may want to restrict the policy further using Custom Path Policy found at http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

4. Inform Team

5. Create Queries

6. Set up project alerts

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 19:54:28 GMT

Installing Code Review

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template.

[image:addcodereviewers.gif]

2. Upload Template

The Code Review.xml file will need to be imported into your project using the witimport.exe.
"VS80COMNTOOLS%\..\IDE\witimport.exe /f "Code Review.xml" /t TFSERVER /p TeamProject

3. Update Check-In Policy

4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 19:49:51 GMT

Installing Code Review

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template.

[image:addcodereviewers.gif]

2. Upload Template

3. Update Check-In Policy

4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 19:49:01 GMT

Installing Code Review

1. Create TFS Code Reviews Group

In your Team Project create a new group named Code Reviewers. These will be the only members allowed to Approve a template.

[image:addcodereviewers.gif]

2. Upload Template

3. Update Check-In Policy

4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 18:11:20 GMT

Installing Code Review

1. Create TFS Code Reviews Group

2. Upload Template

3. Update Check-In Policy

4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 18:10:16 GMT

Installing Code Review

1. Create TFS Code Reviews Group

2. Upload Template

3. Update Check-In Policy

4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 18:09:59 GMT

!Installing Code Review

!!1. Create TFS Code Reviews Group

!!2. Upload Template

!!3. Update Check-In Policy

!!4. Inform Team

UPDATED WIKI: Installation

RyanFarber — Thu, 20 Jul 2006 18:09:36 GMT

!Installing Code Review!

!!1. Create TFS Code Reviews Group!!

!!2. Upload Template!!

!!3. Update Check-In Policy!!

!!4. Inform Team!!

UPDATED WIKI: Home

RyanFarber — Thu, 20 Jul 2006 18:06:27 GMT

TFS Code Review Workflow

Parts

Code Review Work Item
Code Review Custom Check-In Policy
Code Reviewers Security Group
(optional) Custom Path Policy http://www.gotdotnet.com/codegallery/codegallery.aspx?id=96d7da50-0d61-4230-9af9-49684ae9881e

Workflow

Dev finishes code and wants it reviewed so they shelve the changeset and create a Code Review work item and mention the name of the shelf set. This is assigned to a general Code Review team.
People on the code review team have event subscriptions which sends them an e-mail when a workitem is assigned to the Code Review group. One of them will open the work item, review the shelf set and resolve the item as 'Accepted' or 'Needs changes' which assigns it back to the original dev.
Once in an approved state the dev can check-in and associate to the work item which will close it.

What's needed

A custom report to show the reviews, time from open to close, number of attached tasks or bugs, number of activations
More detail in work item?
Some more options to allow for different code reviewer groups. For example on one of my projects the test team want the test code to follow this policy but be assigned to test team code reviewers.
An add-in for VS to automatically shelve and create the workitem.

see installation