TFSCodeReviewFlow Forum Rss Feed

New Post: Get Code review status for a particular shelvset

ajaykumarrudra — Thu, 08 Nov 2012 12:37:26 GMT

when i build is triggered for a particular shelvset i need to get the status of code review. can any help me a code sample in c#.

New Post: Does this works with TFS 2008?

jzserai — Fri, 12 Aug 2011 15:43:36 GMT

Can this work with TFS 2010 and VS 2010 using the same process as above to get it to work in 2008?

Thank you

New Post: We have improvements but cannot contribute

jbbrown — Wed, 28 Oct 2009 21:19:15 GMT

Hi - I think the best thing you can do now is to go the Source Code tab and uplaod a Patch of your changes. At the very least I'd like to look at them!

Thanks

JB Brown

New Post: We have improvements but cannot contribute

ozguloguz — Wed, 28 Oct 2009 16:06:27 GMT

Hi,

We have improvements over the current version and want to contribute. It's a shame that they discontinue development.

1. Auto creation of the code review work item (Not an add-in but asks for confirmation from user during the shelve operation)

2. Comparing the current check-in with the reviewed shelveset and fail on any differences (uses TFS's compare features)

3. Deployment project for handling the client side installation needs. (one click install for the developers)

4. Detailed code review work items

Also,

development is undergoing for the server side deployment project

New Post: Abandoned?

jbbrown — Fri, 16 Oct 2009 17:09:33 GMT

dcanning - Yes, I'm pretty sure it's abandoned. I've been monitoring this forum for a while and doing what i can to help others out, but nobody from the official team seems to have been active for over a year.

New Post: Abandoned?

dcanning — Fri, 02 Oct 2009 17:08:07 GMT

From the activity on this project portal, it would appear to be abandoned, can anyone confirm or deny?

New Post: Does this works with TFS 2008?

jbbrown — Fri, 02 Oct 2009 16:28:16 GMT

mwaseemalvi - I've made these changes and uploaded them to the patch list. Have you already tried that?

http://www.codeplex.com/TFSCodeReviewFlow/SourceControl/PatchList.aspx

New Post: Does this works with TFS 2008?

mwaseemalvi — Fri, 02 Oct 2009 11:10:27 GMT

Dear Muscter

May I know the line of code which I would be add in approved block. I am trying but unable to resolve this issue and unable to apply this policy in TFS2008. Please let me know the details that how can I resolved this issue.

New Post: CheckIn - Work Item Mismatch

bugraKocaturk — Fri, 04 Sep 2009 11:52:47 GMT

Hi,

I've installed the application but I need to ask some questions about it.

1 ) When developer shelves the application, (s)he also needs to create work item manually. Then one of the Code Reviewers will need to resolve it as "Approved" or "Needs Changes". I think there is not any problem so far. But; think about this : the code reviewer Approved the work item and now developer is able to check-in. If the developer changes the code at this point and then associate the new check-in with the previously approved work item; code will be changed but there will be no restriction for check-in. Because, there is an already waiting work item, which is resolved as Approved, for the developer .

2 ) In my case; if the developer chooses "Any Code Reviewer" for "Assigned To" option, the new work item is not shown in "My Work Items" part of each Code Reviewer. Instead it is shown in "All Work Items" part. Is this the intended behaviour?

Thank you for your responses.

New Post: How to install

seaml3ss — Tue, 05 May 2009 23:35:57 GMT

I got the error below to go away by making sure the registry key string name was the same as the dll it referenced

Error loading the Code Review Policy policy (The policy assembly 'Code Review Policy, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' is not registered.).

example :
Registry Setting for HKLM\SOFTWARE\Microsoft\VisualStudio\8.0\TeamFoundation\SourceControl\Checkin Policies\Code Review Policy

Value Name: Code Review Policy
Value Data: C:\Program Files\Microsoft Team Foundation Server 2005 Power Tools\Check-in Policy Pack\Code Review Policy.dll

Not sure if this helps anyone

New Post: Does this works with TFS 2008?

jbbrown — Sun, 08 Feb 2009 22:56:13 GMT

See the patch list

http://www.codeplex.com/TFSCodeReviewFlow/SourceControl/PatchList.aspx

New Post: Policy Enforcement

jbbrown — Sun, 08 Feb 2009 22:55:22 GMT

See the patch list

http://www.codeplex.com/TFSCodeReviewFlow/SourceControl/PatchList.aspx

New Post: Policy Enforcement

mucster — Wed, 03 Dec 2008 18:11:14 GMT

Just in case anyone is interested, there is a bug in the code that will allow a checkin without approval. This is caused by the boolean allCodeReviewsApproved being defaulted to true. Change the default to false and add a line of code inside the "If ... Approved" block.)

You can get this to work in VS 2008 using the following steps:

Download the source code
Open project and convert to VS 2008
Remove all references to the Team Foundation Server objects (Make required coding changes)
Add new references for the Team Foundation Server objects
Build code
Overwrite old DLL with VS 2008 version

New Post: Does this works with TFS 2008?

mucster — Wed, 03 Dec 2008 18:08:38 GMT

This will not work in VS 2008 straight from the download. This was built with the version 8.0 objects for Team Foundation Server.
You can get this to work in VS 2008 using the following steps:

Download the source code
Open project and convert to VS 2008
Remove all references to the Team Foundation Server objects (Note:
There is a bug in the code that will allow a checkin without approval. This is caused by the boolean allCodeReviewsApproved being defaulted to true. Change the default to false and add a line of code inside the "If ... Approved" block.)
Add new references for the Team Foundation Server objects
Build code
Overwrite old DLL with VS 2008 version

New Post: How to install

Spryder — Thu, 06 Nov 2008 21:01:14 GMT

Trying to get this to work. Server side went without a hitch. I created the registry key on the client as defined. Client side fails with an internal error. When I go back to the project -> Team Project Settings -> source control I get the following error message:

---------------------------
Microsoft Visual Studio
---------------------------
Error

Error loading the Code Review Policy policy (The policy assembly 'Code Review Policy, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' is not registered.).

Installation instructions:
---------------------------
OK
---------------------------
Any ideas? Is there a client side install package available?

NEW POST: Does this works with TFS 2008?

niksac — Mon, 26 May 2008 07:37:05 GMT

Hi

I installed this as per the instructions given, I was able to import the xml into TFS but I do not see the policies coming in Team Explorer.
was wondering is this works with 2008?

Thanks
Nik

NEW POST: How to install

wcbrown — Wed, 14 Nov 2007 16:12:21 GMT

Same here. It's a shame because I really could use a Code Review Work Item.

NEW POST: Compatibility with Guy Kolbis - Code Review Add-In

JBBrown — Sun, 03 Jun 2007 09:42:59 GMT

Hi, There's a bit of information here about working with both the TFS Code Review Workflow and Guy Kolbis - Code Review Add-In as part of one code review process.

http://www.bloglines.com/blog/JBBrown?id=4

Thanks,
JB

How to install:

danfairs — Mon, 26 Feb 2007 11:41:27 GMT

Did this ever get resolved? I'm seeing the same thing.

User Forum: RE: How to install

Kishilov — Tue, 24 Oct 2006 14:35:06 GMT

Hi, When I'm trying to execute witimport /f "Code Review.xml" /t tfs /p project, it gives me the following error message: Workitem Type Import failed to make the requested rule changes. Any ideas why it happens? (Code Reviewers group is already created for the project) Thank You!