Policy Enforcement

Topics: User Forum
Sep 7, 2006 at 3:08 PM
Hi,

I've managed to get the policy setup in team system and have installed it on my machine

However the policy is not being enforced in the way I expected, team system quite happily lets me check in as long as the change set has a code review item associated with it (even though the code review work item is still active). Is this what I should be expecting.

I should also say that, although I haven't tried it yet, Custom Path Policy looks great. Exactly what I need.

Thanks,

Colin Jack

Thanks,

Colin
Dec 3, 2008 at 5:11 PM
Just in case anyone is interested, there is a bug in the code that will allow a checkin without approval.  This is caused by the boolean allCodeReviewsApproved being defaulted to true.  Change the default to false and add a line of code inside the "If ... Approved" block.)

You can get this to work in VS 2008 using the following steps:
  1. Download the source code
  2. Open project and convert to VS 2008
  3. Remove all references to the Team Foundation Server objects (Make required coding changes)

     

  4. Add new references for the Team Foundation Server objects
  5. Build code
  6. Overwrite old DLL with VS 2008 version
Feb 8, 2009 at 9:55 PM
See the patch list

http://www.codeplex.com/TFSCodeReviewFlow/SourceControl/PatchList.aspx